fix(mcp,text): MCP activation hints and enable_thinking retry - #126
Open
hopelynd wants to merge 4 commits into
Open
fix(mcp,text): MCP activation hints and enable_thinking retry#126hopelynd wants to merge 4 commits into
hopelynd wants to merge 4 commits into
Conversation
…s false Non-streaming chat no longer forces enable_thinking=false, which breaks thinking-only models. Retry once with false only when the server demands it.
… MCP activation on 404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpMarketplaceDetailPage).activate-hinthelpers and apply them tosearch web,mcp tools, andmcp call(skipped when--urloverrides the endpoint).text chatenable_thinkinghandling: omit the field by default for streaming, setfalsefor non-streaming, and retry once when the API returns a clear constraint error.thinking_budgetacrossenable_thinkingretries viaapplyChatEnableThinkingWithBudget.Test plan
vp check(format, lint, type check)packages/core/tests/thinking.test.tspackages/commands/tests/mcp-activate-hint.test.tspackages/commands/tests/search-web-activate-hint.test.tsbl search web --query "test"against an account without WebSearch MCP activated and verify the hint includes the marketplace URLbl mcp tools --server <code>/bl mcp call --target <code>.<tool>against an unactivated MCP and verify server-specific hintbl text chat --thinking-budget 2048on a model that requiresenable_thinkingretry and confirm the retried request includesthinking_budget